Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About logo icon doesn't denote chain type (?) in About/ Help message window/ dialog #761

Open
1 task done
pablomartin4btc opened this issue Sep 24, 2023 · 2 comments · May be fixed by #762
Open
1 task done

About logo icon doesn't denote chain type (?) in About/ Help message window/ dialog #761

pablomartin4btc opened this issue Sep 24, 2023 · 2 comments · May be fixed by #762

Comments

@pablomartin4btc
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current behaviour

BitcoinQT shows the same about logo icon (orange colour) in all chain type instances, not being consistent with the task bar icon or initia/ start dialog:

image

Expected behaviour

I think showing the correct icon (colour) that indicates the chain type as in the splash screen (first/ initial dialog when qt starts) and task bar app icon.

Steps to reproduce

Run bitcoin-qt and bitcoin-qt -regnet (or -signet/ -tesnet), click on or press Alt-H and select "About Bitcoin Core", a window with the same title as of the previous selected menu item will popup showing the classic Bitcoin orange icon at the top left corner.

Relevant log output

No response

How did you obtain Bitcoin Core

Compiled from source

What version of Bitcoin Core are you using?

v25.99

Operating system and version

Ubuntu 22.04

Machine specifications

No response
@pablomartin4btc pablomartin4btc linked a pull request Sep 25, 2023 that will close this issue
Open
@maflcko
Copy link
Contributor

maflcko commented Feb 13, 2024

Not sure. See #762 (comment)

@pablomartin4btc
Copy link
Contributor Author

Thanks, I agree with your point and I couldn't find any recommendations regarding this kind of approach either way. I tend to agree more with @GBKS's comment on this matter since that's the spirit of my change, to be in accordance with the other components (splash screen and task-bar icons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@maflcko @pablomartin4btc