Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Receiving addresses by index (or creation date) #694

Open
Sjors opened this issue Jan 2, 2023 · 2 comments
Open

Sort Receiving addresses by index (or creation date) #694

Sjors opened this issue Jan 2, 2023 · 2 comments
Labels

Comments

@Sjors
Copy link
Member

Sjors commented Jan 2, 2023

Under Window -> Receiving addresses the list can only be sorted by Label or Address. Both are inconvenient if e.g. you have two labels "Blah Jan 2022" and "Blah Jan 2022", and now you need to rename the most recent one to 2023.

Sorting by the index could make sense (but is still ambiguous with multiple descriptors), or by label creation time.

@Sjors Sjors added the Feature label Jan 2, 2023
@john-moffett
Copy link
Contributor

I think only manually 'requested' receiving addresses have dates or independent IDs associated with them at the moment. (Stored via destdata entries in the wallet db.)

Is the suggestion to populate that data (and allow sorting on it) in this table if it's available, or would the change be more extensive and involve updating the data in the DB if the label is set/modified in this window?

@Sjors
Copy link
Member Author

Sjors commented Jan 3, 2023

and involve updating the data in the DB if the label is set/modified in this window

I would probably keep it as simple as possible. You also don't really want to move things around once the user saves something.

I guess unused labels can go to the bottom?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants