Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Open Wallet" popup text #679

Open
mmikeww opened this issue Nov 13, 2022 · 2 comments
Open

Change "Open Wallet" popup text #679

mmikeww opened this issue Nov 13, 2022 · 2 comments

Comments

@mmikeww
Copy link

mmikeww commented Nov 13, 2022

Is your feature request related to a problem? Please describe.

When I use the menu for File -> Open Wallet, I get a popup saying "Opening wallet xxx...." with a progress bar. There is no other information. The progress bar just loops endlessly. I can of course close this popup by clicking the X normally. If I try to use the menu item again, I get the same popup and the same looping progress bar.

image

Initially I thought this was a bug, and was in the process of submitting a bug report, until I checked debug.log. I shouldn't have to check a log file to understand whats happening. Inside I found these lines:

2022-11-13T16:24:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 752699. Progress=0.977750
2022-11-13T16:25:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 753057. Progress=0.978535
2022-11-13T16:26:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 753399. Progress=0.979322
2022-11-13T16:27:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 753844. Progress=0.980183

Waiting until this process completed allowed the wallet to open.

Describe the solution you'd like

I think the text on that popup window should be changed to be more descriptive for the user. The current text of "Opening wallet....." with nothing but a looping progress bar, initially led me to believe that the wallet file was corrupted or something. That maybe Core couldn't open it, and was just hung or looped.

The text should be changed to something like "Syncing wallet with chain..." or however you want to word it, additionally with a progress bar that show's the actual percentage like is shown inside the log file.

@katesalazar
Copy link
Contributor

katesalazar commented Nov 14, 2022 via email

@pablomartin4btc
Copy link
Contributor

This is kind of duplicated with #651, but I appreciate the level of details, I agree with the change of the title of the window + updating the progress bar with the actual progress to enhance accuracy but to avoid confusion as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@mmikeww @hebasto @katesalazar @pablomartin4btc and others