Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No obvious way to close peer detail panel #485

Open
rebroad opened this issue Nov 25, 2021 · 3 comments · May be fixed by #505
Open

No obvious way to close peer detail panel #485

rebroad opened this issue Nov 25, 2021 · 3 comments · May be fixed by #505
Labels
Feature

Comments

@rebroad
Copy link
Contributor

rebroad commented Nov 25, 2021

When clicking on a peer in the peer table, a panel is displayed, but there seems to be no obvious way to close this once opened.
@rebroad rebroad added the Bug Something isn't working label Nov 25, 2021
@shaavan
Copy link
Contributor

shaavan commented Nov 25, 2021

We could close the panel by clicking in the empty area. Though it's not immediately apparent, I don't think it's a bug per se.

@jarolrod
Copy link
Member

you could make the splitter have dual functionality by adding in an arrow that would be a button, like so:

|    
|    # splitter functionality: resize
|
>   # Close the pane
|
|    # splitter functionality: resize
|

@jarolrod jarolrod added Feature and removed Bug Something isn't working labels Nov 28, 2021
@RandyMcMillan
Copy link
Contributor

I was thinking about this recently - I will post something.

@RandyMcMillan RandyMcMillan linked a pull request Dec 12, 2021 that will close this issue
Open
RandyMcMillan added a commit to RandyMcMillan/gui that referenced this issue Jan 29, 2022
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetail() button and implementation
3326ba1 
Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to RandyMcMillan/gui that referenced this issue Jan 29, 2022
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clea…
9456ab3 
…rSelectedNode

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Jan 29, 2022
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clea…
2ae79d0 
…rSelectedNode

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to RandyMcMillan/gui that referenced this issue Feb 3, 2022
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clea…
4714693 
…rSelectedNode

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Nov 15, 2022
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clea…
d59363a 
…rSelectedNode

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Sep 20, 2023
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clea…
f05fe91 
…rSelectedNode

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Mar 28, 2024
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clea…
cc7b9a1 
…rSelectedNode

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Mar 28, 2024
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clea…
7f59492 
…rSelectedNode

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Mar 28, 2024
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clea…
bfe9c26 
…rSelectedNode

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Mar 28, 2024
@RandyMcMillan @w0xlt
RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clea…
436ac4f 
…rSelectedNode

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Mar 28, 2024
@RandyMcMillan
debugwindow.ui:hidePeersDetailButton
00000b8 
    
    Add a close (X) button to the Peers Detail panel.
    Reuse the same icon used in the Console Tab.
    The close button deselects the peer highlighted
    in the PeerTableView and hides the detail panel.
    This PR addresses issue bitcoin-core#485:
    
    Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
06-0005a37a
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Mar 29, 2024
@RandyMcMillan @w0xlt
debugwindow.ui:hidePeersDetailButton
f722065 
Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
RandyMcMillan added a commit to bitcoincore-dev/gui that referenced this issue Apr 9, 2024
@RandyMcMillan @w0xlt
gui: Hide peers details
41a1a86 
Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue bitcoin-core#485:

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide peers details bitcoincore-dev/gui
4 participants
@RandyMcMillan @rebroad @jarolrod @shaavan