Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect non-x86 Linux systems on Download page #696

Open
harding opened this issue Feb 6, 2020 · 1 comment
Open

Auto-detect non-x86 Linux systems on Download page #696

harding opened this issue Feb 6, 2020 · 1 comment

Comments

@harding
Copy link
Contributor

harding commented Feb 6, 2020

The big blue button on the download page uses the browser user agent string to recommend a binary for the user to download. Presently it only recommends x86 binaries for Linux users. Either it should also recommend ARM and RISCV binaries for those users or we should just get rid of the button and so encourage users to select their own platform.

2020-02-06-09_06_51_451502339

List of popular browser strings to test matching against: https://www.whatismybrowser.com/detect/what-is-my-user-agent

Help needed: I don't see any browser strings on the above list for RISCV. Does X11 run on that platform? If so, anyone running a graphical browser could help by replying with their browser string (e.g. as reported here).

Previous discussion: #695 (review)

@katesalazar
Copy link
Contributor

Presently it only recommends x86 binaries for Linux users. Either it should also recommend ARM and RISCV binaries for those users or we should just get rid of the button and so encourage users to select their own platform.

I think it should recommend all of x86, ARM, RISCV, whatnot, Linux binaries (maybe ordered by "common sense", dunno), until you find the way to reliably detect the computer type/architecture. I would suggest not removing the big blue button. I think there can't be three links in the button, so the hell with it and add as many big blue buttons as architectures.

The architecture problem hitting Apple as well is imminent, I suppose.


BTW my resolution totally wrecks the big blue button off.

Typical:
Screen Shot 2022-04-19 at 23 39 36

Artificially enlarged:
Screen Shot 2022-04-19 at 23 40 42

Will try to tweak and if get anything interesting add ticket and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants