Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-merge.py fails when log.showSignature true is set #133

Open
fanquake opened this issue May 17, 2022 · 1 comment
Open

github-merge.py fails when log.showSignature true is set #133

fanquake opened this issue May 17, 2022 · 1 comment

Comments

@fanquake
Copy link
Member

Due to:

assert len(head_commit) == 40

@laanwj
Copy link
Member

laanwj commented May 18, 2022

I wonder if there's a way to reduce the script's dependency on specific git settings having a certain value.

That said, the most straightforward fix is to make it another thing overridden on the command line when calling the appropriate commands.

@bitcoin-core bitcoin-core deleted a comment Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants