Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: GitHub Action for bitexpert/phpstan-magento #49

Open
shochdoerfer opened this issue Dec 19, 2020 · 9 comments
Open

Feature Request: GitHub Action for bitexpert/phpstan-magento #49

shochdoerfer opened this issue Dec 19, 2020 · 9 comments

Comments

@shochdoerfer
Copy link
Member

Build a GitHub Action to let phpstan-magento run in GitHub build pipelines automatically. Check what the extdn people have done for their actions and adapt https://github.com/extdn/github-actions-m2

@shochdoerfer
Copy link
Member Author

@torhoehn did you hack on that during the Firegento Hackathon?

@torhoehn
Copy link
Contributor

torhoehn commented Feb 8, 2021

@shochdoerfer No, I was a little bit late, so @frostblogNet proposed this topic. As I have arrived @schmengler looked for a partner, so we worked together on something else.

@shochdoerfer
Copy link
Member Author

No worries, just saw on Twitter that this topic was proposed. Wanted to avoid that we both work on this and no one is aware ;)

@torhoehn
Copy link
Contributor

@shochdoerfer Is this solved, because the repo already runs GitHub Actions or do you thinking about extending this?

@shochdoerfer
Copy link
Member Author

Not yet solved. The goal was to have GitHub Action with PHPStan and this extension so that others could run it easily in their GitHub CI pipeline. Similar to what the extdn are doing: https://github.com/extdn/github-actions-m2/tree/master/magento-phpstan

@torhoehn
Copy link
Contributor

Ah now I remember. While writing my previous comment I wasn't in the correct context.

@shochdoerfer
Copy link
Member Author

No worries, that happens ;) Still, if you feel, you wanna tackle it, let me know.

@torhoehn
Copy link
Contributor

Started yesterday to play around with it.

@shochdoerfer
Copy link
Member Author

It could be that it is possible to use the phpstan GitHub Action provided by the extdn people: https://github.com/extdn/github-actions-m2/tree/master/magento-phpstan

Check and document!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants