Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A whitelist entry is not editable Error after trying to update the module #230

Closed
iranimij opened this issue Apr 5, 2024 · 2 comments
Closed
Milestone

Comments

@iranimij
Copy link

iranimij commented Apr 5, 2024

After updating the module from 4.1 to 5.3 and then after running bin/magento set:up, I receive this error.

Unable to apply data patch BitExpert\ForceCustomerLogin\Setup\Patch\Data\Patch501 for module BitExpert_ForceCustomerLogin. Original exception message: Whitelist entry not editable.

I took a look into it and found the source of the issue. The issue is that, previously we have added some records to the bitexpert_forcelogin_whitelist with editable 0 by default. (https://github.com/bitExpert/magento2-force-login/blob/7cdd89556ba2cfbadb38565f6405eeea94b7f43e/Setup/UpgradeData.php#L235C9-L241C11) using setup script and then in version 5 we return error if the editable is 0, and I think when we are making editable automatically 0 then we should not return exception in future
https://github.com/bitExpert/magento2-force-login/blob/master/Repository/WhitelistRepository.php => line 79

Preconditions

Updating from Magento2-force-login version 4.1 to version 5.3
PHP 8.2

Magento Version : 2.4.6-p4

Force Login Module Version :

Third party modules :

Steps to reproduce

  1. Install module 4,1
  2. update to 5.1
  3. run bin/magento set:up

Expected result

  1. No error should we see. since everything is ok.

Actual result

  1. We receive an error :

image

@iranimij
Copy link
Author

iranimij commented Apr 5, 2024

I have prepared this pr for this issue : #231

@shochdoerfer shochdoerfer added this to the 5.4.0 milestone May 1, 2024
@shochdoerfer
Copy link
Member

Fixed in the 5.4.0 release which was just published https://github.com/bitExpert/magento2-force-login/releases/tag/v5.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants