Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be blocking use account creation in the scope of the module? #127

Closed
amenk opened this issue Sep 27, 2018 · 6 comments
Closed

Would be blocking use account creation in the scope of the module? #127

amenk opened this issue Sep 27, 2018 · 6 comments

Comments

@amenk
Copy link

amenk commented Sep 27, 2018

We have an invite-only shop. Would it be in scope of the module to block also to implement such a thing:

https://magento.stackexchange.com/a/168151/81

Then I would make a pull request ...

@amenk
Copy link
Author

amenk commented Sep 27, 2018

Actually there is already a FOSS module for this: https://github.com/deved-it/magento2-disable-customer-registration
so better leave it there?

@der-workfloh
Copy link
Contributor

der-workfloh commented Sep 27, 2018

Hi @amenk

thanks for the feedback and the thoughts. Currently, you can remove the registration page from the whitelist (if an entry exists), so no customer would be able to register on their own. Alternativly, you could use another module to explicitly disable registration.

Best regards

@amenk
Copy link
Author

amenk commented Sep 27, 2018

It would be still available via API then ...

@amenk amenk closed this as completed Sep 27, 2018
@shochdoerfer
Copy link
Member

@websharp do we also want to disable API calls with this module? Would that be a use case for us?

@amenk
Copy link
Author

amenk commented Sep 27, 2018

Oh you, don't ? :D
If the use case is, that a shop catalog should be only visible via login, data should not be leaked via APIs though I think

@amenk
Copy link
Author

amenk commented Sep 27, 2018

#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants