Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace an "isIPv6Address()" with python package "ipaddress" #1686

Closed
buhtz opened this issue Apr 13, 2024 · 3 comments · Fixed by #1689
Closed

Replace an "isIPv6Address()" with python package "ipaddress" #1686

buhtz opened this issue Apr 13, 2024 · 3 comments · Fixed by #1689
Assignees
@buhtz @jarbhav
Labels
Low relevant, but not urgent
Milestone
Upcoming release ...

Comments

@buhtz
Copy link
Member

buhtz commented Apr 13, 2024

Replace this method isIPv6Address() with Python in-build ipaddress package introduce with Python 3.3.

backintime/common/tools.py

Line 1849 in d33f35e

if isIPv6Address(address):

This is the only place this function is used. Remove the code and its unit tests.
@buhtz buhtz self-assigned this Apr 13, 2024
@buhtz buhtz added the Low relevant, but not urgent label Apr 13, 2024
@buhtz buhtz added this to the Upcoming release (1.5.0) milestone Apr 13, 2024
@buhtz buhtz mentioned this issue Apr 13, 2024
Merged
@jarbhav
Copy link
Contributor

jarbhav commented Apr 14, 2024

@buhtz I would like to work on this, if it's still available.

@buhtz
Copy link
Member Author

buhtz commented Apr 14, 2024

Hello Vaibhav,
OK, you are in. Thanks for you offer.

Best,
Christian

@jarbhav
Copy link
Contributor

jarbhav commented Apr 15, 2024 •
edited

Hi Christian,
I have opened PR #1689 addressing this, please let me know if any changes are needed.

Thanks,
Vaibhav

@jarbhav jarbhav mentioned this issue Apr 15, 2024
Merged
buhtz added a commit that referenced this issue May 23, 2024
@jarbhav @buhtz
refactor: Replace isIPv6Address() with Python own ipaddress package
e6f7f4f 
Remove isIPv6Address() function and replace it with Pythons own ipaddress package.

Closes #1686

Thank to Vaibhav Raj (@jarbhav) for contributing.
---------

Co-authored-by: buhtz <c.buhtz@posteo.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buhtz buhtz

@jarbhav jarbhav

Labels
Low relevant, but not urgent
Projects
None yet
Milestone
Upcoming release (1.5.0)
Development

Successfully merging a pull request may close this issue.

Replace isipv6 method with builtin package jarbhav/backintime
2 participants
@buhtz @jarbhav