Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: --copy-links may cause huge backups #1652

Open
aryoda opened this issue Feb 22, 2024 · 3 comments
Open

Documentation: --copy-links may cause huge backups #1652

aryoda opened this issue Feb 22, 2024 · 3 comments

Comments

@aryoda
Copy link
Contributor

aryoda commented Feb 22, 2024

The use of --copy-links should be mentioned in our FAQ as a reason for huge backups (if the backups source folder contains one or multiple links to target folder with large disk space consumption).

Also a clear warning in the GUI could be helpful too (as tooltip or in the checkbox label):

image

@emtiu
Copy link
Member

emtiu commented Feb 22, 2024

I agree that "Copy links (dereference symbolic links)" is a confusing description. I think "Follow symbolic links" would be much clearer.

We might even consider spelling out the literal rsync options that our settings include. In that case, this checkbox (and other, accordingly) might be labelled: "--copy-links: Follow symbolic links"

I'm also fine with an FAQ entry to warn of including symlinks to large folders with this option.

But I don't think we need to issue an extra warning in the GUI. If people click around in the "Expert options" to activate an option regarding symbolic links, and they have symbolic links to huge folders in their included paths, then I think they can be expected to understand the consequences.

Or am I out of touch? ;)

@buhtz
Copy link
Member

buhtz commented Feb 22, 2024

FAQ is good idea.

I agree that "Copy links (dereference symbolic links)" is a confusing description.
...
"--copy-links: Follow symbolic links"

I like that idea.

Brings me again to a big redesign of the settings dialog. ;)
Maybe "Follow symbolic links" is a good start to prevent an exploding PR. 🤣

Or am I out of touch? ;)

No. Especially people clicking around in Expert Options do operate on their own risk. ;)

@aryoda
Copy link
Contributor Author

aryoda commented Feb 22, 2024

Totally fine for me (nothing to add 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants