Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make demos self-encapsulated #11

Open
leoj3n opened this issue May 10, 2017 · 1 comment
Open

Make demos self-encapsulated #11

leoj3n opened this issue May 10, 2017 · 1 comment

Comments

@leoj3n
Copy link
Contributor

leoj3n commented May 10, 2017

If you have a demo like:

https://github.com/canjs/canjs/blob/master/demos/can-stache-bindings/event-args.html

It is using whatever steal is in the root node_modules (two levels up).

I think it would be better if demos with dependencies had their own node_modules and package.json, with locked-down versions.

Kind of like how you can add dependencies to the html hook that bit-docs-generate-html will automatically install (using enpeem under the hood):

https://github.com/canjs/bit-docs-html-canjs/blob/master/make-example.js#L17-L19

So, probably bit-docs-tag-demo could detect an package.json and run enpeem on it.

It would be good to have the versions of the dependencies the demo relies on locked down, to avoid inadvertently breaking demos when upgrading top-level dependencies.

@leoj3n
Copy link
Contributor Author

leoj3n commented Sep 21, 2017

/cc @justinbmeyer we touched on this at next I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant