Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devBuild not respected in mustache template #26

Open
leoj3n opened this issue Apr 25, 2017 · 3 comments
Open

devBuild not respected in mustache template #26

leoj3n opened this issue Apr 25, 2017 · 3 comments

Comments

@leoj3n
Copy link
Contributor

leoj3n commented Apr 25, 2017

The devBuild option set to true still seems to evaluate to false in this mustache:

https://github.com/bit-docs/bit-docs-generate-html/blob/minor/site/default/templates/layout.mustache

@leoj3n
Copy link
Contributor Author

leoj3n commented Apr 25, 2017

See this repo for repro: https://github.com/leoj3n/generate-temp#devbuild-issue

@leoj3n
Copy link
Contributor Author

leoj3n commented Apr 25, 2017

Even this doesn't see to make a difference:

diff --git a/build/build_hash.js b/build/build_hash.js
index 31abe40..6c2b29d 100644
--- a/build/build_hash.js
+++ b/build/build_hash.js
@@ -32,6 +32,7 @@ module.exports = function(options){
                        values[key] = options[key];
                }
        });
+       values["devBuild"] = true;

        return md5(JSON.stringify(values));
 };

@leoj3n
Copy link
Contributor Author

leoj3n commented Oct 24, 2018

Not sure if this is still an issue, would probably want to re-test with latest versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant