-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add available BSQ amount to top menu bar #6709
Conversation
Thanks for this. How does this display if a user has say 5 figures in BSQ? |
b175bcb
to
898e44a
Compare
@pazza83 I've added a few more screenshots that present this feature in a different scenarios |
It looks great. Many thanks for doing this. Looking forward to seeing this added to Bisq. |
Is the layout still ok with the max. number of decimals? |
I think having the amount fixed top right works well. Makes casual users aware that BSQ exists. That was part of the reason behind the creation of the issues. Increase BSQ awareness. |
I understand the motivation to show the BSQ balance in the top menu bar, but I think it clutters the UI. IMO it's better to show the makers (at offer creation) and takers (when taking an offer) how much they would save by using BSQ. Nevertheless, I'm not against this change. |
I created the issue following new user feedback saying they would like to see their BSQ balance at a glance. Another user had sent them BSQ to funds there trade fees for their first few trades but they could not find what their balance was. I do think it makes sense to show the BSQ balance in the top right rather than a few screens deep as it currently is. I think there is enough space in the top bar (when using in full screen mode) for the addition of the BSQ balance not to add clutter. I think this change is good as part of a number of changes needed to make BSQ more prominent in Bisq. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Would be good to get this added still @helixx87 where are you up to with this? |
I'm closing this pull request for now. Feel free to reopen it when ready! |
Fixes #6660