Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add available BSQ amount to top menu bar #6709

Closed
wants to merge 1 commit into from

Conversation

helixx87
Copy link
Contributor

@helixx87 helixx87 commented May 20, 2023

Fixes #6660

bsq-balance

topbar-2

topbar-2b

topbar-3

@pazza83
Copy link

pazza83 commented May 20, 2023

@helixx87

Thanks for this.

How does this display if a user has say 5 figures in BSQ?

@helixx87
Copy link
Contributor Author

@pazza83 I've added a few more screenshots that present this feature in a different scenarios

@pazza83
Copy link

pazza83 commented May 21, 2023

@helixx87

It looks great. Many thanks for doing this.

Looking forward to seeing this added to Bisq.

@HenrikJannsen
Copy link
Collaborator

Is the layout still ok with the max. number of decimals?
An alternative could be to let BTC and BSQ balance flip on mouse click and if not clicked to let them cross fade with a animation. so the user can see the other balace every 3 sec or so. we can do that only if there is a non zero BSQ balance.

@pazza83
Copy link

pazza83 commented May 21, 2023

we can do that only if there is a non zero BSQ balance.

I think having the amount fixed top right works well.

Makes casual users aware that BSQ exists. That was part of the reason behind the creation of the issues. Increase BSQ awareness.

@alvasw
Copy link
Contributor

alvasw commented May 23, 2023

I understand the motivation to show the BSQ balance in the top menu bar, but I think it clutters the UI. IMO it's better to show the makers (at offer creation) and takers (when taking an offer) how much they would save by using BSQ. Nevertheless, I'm not against this change.

@pazza83
Copy link

pazza83 commented May 23, 2023

I created the issue following new user feedback saying they would like to see their BSQ balance at a glance.

Another user had sent them BSQ to funds there trade fees for their first few trades but they could not find what their balance was.

I do think it makes sense to show the BSQ balance in the top right rather than a few screens deep as it currently is.

I think there is enough space in the top bar (when using in full screen mode) for the addition of the BSQ balance not to add clutter.

I think this change is good as part of a number of changes needed to make BSQ more prominent in Bisq.

@HenrikJannsen
Copy link
Collaborator

HenrikJannsen commented May 24, 2023

The BSQ field is truncated even with small amounts:
Screenshot 2023-05-24 at 07 54 00

And more truncated with large amounts:
Screenshot 2023-05-24 at 07 51 51

If the app has min. screen width the balance fields are truncated:
Screenshot 2023-05-24 at 07 50 53

Without the new field we also have truncated the balance fields, which is also not great.
Screenshot 2023-05-24 at 07 58 50

One option to solve that would be to pack the available/reserved and locked balance into a combobox, similar as the price box and show available by default. We could do that only if the screen width is too small, otherwise we can expand the fields as it is now.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@pazza83
Copy link

pazza83 commented Jul 19, 2023

Would be good to get this added still @helixx87 where are you up to with this?

@alejandrogarcia83
Copy link
Contributor

I'm closing this pull request for now. Feel free to reopen it when ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add available BSQ amount to top menu bar in client
5 participants