Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cookies with local storage #3790

Closed
2 tasks
jonrkarr opened this issue Dec 10, 2021 · 4 comments
Closed
2 tasks

Replace cookies with local storage #3790

jonrkarr opened this issue Dec 10, 2021 · 4 comments
Assignees
@bilalshaikh42
Labels
released

Comments

@jonrkarr
Copy link
Member

jonrkarr commented Dec 10, 2021 •
edited

@bilalshaikh42 bilalshaikh42 self-assigned this Dec 13, 2021
@bilalshaikh42
Copy link
Member

h5bp/html5-boilerplate#1444 (comment)

@bilalshaikh42
Copy link
Member

@jonrkarr this is effectively done. It was not as simple as I thought since the new version of google analytics does not support the configuration as above. I was able to use google tag manager to set up the config, but we effectively lose all information other than page views.

Looking at the following two pages, I think we can actually leave the cookies in. The cookies are used to keep track of sessions, not track users. I think this falls under performance cookies, and should not be a problem Perhaps we can clarify this in the policy/ submissions.

https://www.cookiepro.com/knowledge/tracking-cookie/
https://www.cookiepro.com/knowledge/what-are-performance-cookies/

@jonrkarr
Copy link
Member Author

jonrkarr commented Dec 15, 2021 •
edited

Using cookies and describing them "performance cookies" seems fine to me. Nucleic Acids specifically says "tracking cookie". In that case, please revise the statement in the privacy policy (docs/about/privacy.md).

bilalshaikh42 added a commit that referenced this issue Dec 15, 2021
@bilalshaikh42
refactor: organized analytics and consent services, styled consent co…
1443717 
…mponents

refactored consent and analytics to load config from configservice. Added better explanations and
examples of the various cookies types. Cleaned up the styling of the consent window. Includes fixes by @jonrkarr

closes #3790

Co-authored-by: Jonathan Karr  <jonrakrr@gmail.com>
bilalshaikh42 added a commit that referenced this issue Dec 15, 2021
@bilalshaikh42 @jonrkarr
refactor: organized analytics and consent services, styled consent co…
c604447 
…mponents

refactored consent and analytics to load config from configservice. Added better explanations and
examples of the various cookies types. Cleaned up the styling of the consent window. Includes fixes by @jonrkarr

closes #3790

Co-authored-by: Jonathan Karr <jonrkarr@gmail.com>
bilalshaikh42 added a commit that referenced this issue Dec 16, 2021
@bilalshaikh42 @jonrkarr
refactor: organized analytics and consent services, styled consent co…
9da76a1 
…mponents

refactored consent and analytics to load config from configservice. Added better explanations and
examples of the various cookies types. Cleaned up the styling of the consent window. Includes fixes by @jonrkarr

closes #3790

Co-authored-by: Jonathan Karr <jonrkarr@gmail.com>
@biosimulations-daemon
Copy link
Collaborator

🎉 This issue has been resolved in version 8.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bilalshaikh42 bilalshaikh42

Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonrkarr @bilalshaikh42 @biosimulations-daemon