Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Missing information in the contributing section #147

Open
3 tasks
ematipico opened this issue Feb 19, 2024 · 4 comments 路 May be fixed by #148
Open
3 tasks

馃悰 Missing information in the contributing section #147

ematipico opened this issue Feb 19, 2024 · 4 comments 路 May be fixed by #148
Labels
Enhancement Improves an existing feature Good first issue

Comments

@ematipico
Copy link
Member

Extension version

main

Biome version

main

Operating system

  • Windows
  • macOS
  • Linux

Description

The current CONTRIBUTING.md document doesn't explain how a contributor can bundle the VSCode extension, and it doesn't explain how to launch VSCode with the bundled extension.

Steps to reproduce

  1. Open the document CONTRIBUTING.md
  2. Check the Development header
  3. It mentions a watch mode for debugging, but it's unclear how it works. I pressed in F5, but it didn't do anything

Expected behavior

I would expect more information for people who aren't accustomed to the developments of the project

Does this issue occur when using the CLI directly?

Not sure / Not applicable

Logs

No response

@nhedger nhedger added Enhancement Improves an existing feature Good first issue and removed Triage labels Feb 19, 2024
@nhedger
Copy link
Member

nhedger commented Feb 19, 2024

AFAIK, the F5 shortcut is VS Code's default to start the debugger, so it should work out of the box. Could you try running the Debug: Start Debugging command from the command palette and see if this works?

@nhedger nhedger linked a pull request Feb 19, 2024 that will close this issue
@ematipico
Copy link
Member Author

I pressed F5 when I opened VSCode, and it didn't do anything. I opened a project and went to the plugin page, and it worked.

Does F5 work when a project is open?

@nhedger
Copy link
Member

nhedger commented Feb 19, 2024

Should work within the extension's project.

Screen.Recording.2024-02-19.at.20.19.38.mov

@ematipico
Copy link
Member Author

ematipico commented Feb 19, 2024

Oh, then I didn't understand how it works 馃槄

Sorry, looking at this flow for the first time and I'm having a hard time. Consider that my experience is very basic and there might be a lot of steps that I'm missing. Does it open two instances of VSCode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improves an existing feature Good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants