Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_properties_changed should be used where appropriate #195

Open
2 tasks
irgolic opened this issue Jul 11, 2021 · 0 comments
Open
2 tasks

node_properties_changed should be used where appropriate #195

irgolic opened this issue Jul 11, 2021 · 0 comments

Comments

@irgolic
Copy link
Member

irgolic commented Jul 11, 2021

(transferring from #191 so it doesn't get lost)

Until now, canvas-core was not aware of changes to settings in widget-base. It only knew to call sync_node_properties to pack Settings when saving. We have added a node_properties_changed signal, intended to be emitted by subclasses of Scheme. (for widget-base, this is implemented in biolab/orange-widget-base#151)

The following improvements should be relatively trivial to implement. There's probably some more uses for it elsewhere.

  • save crash recovery state also on Setting change, not just workflow change (CanvasMainWindow.save_swp). Also, the workflow should freeze when restoring crashed state, so a perpetually crashing state is not restored.
  • set SchemeEditWidget as modified on Setting change. With this change, Orange should be acutely aware of when the workflow is and is not modified. No more 'do you want to save?' when no changes have been made.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant