Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI not testing oldest supported python version #366

Closed
twizmwazin opened this issue Apr 10, 2024 · 2 comments · Fixed by #367
Closed

CI not testing oldest supported python version #366

twizmwazin opened this issue Apr 10, 2024 · 2 comments · Fixed by #367
Labels
bug Something isn't working

Comments

@twizmwazin
Copy link
Collaborator

Description

Right now the CI tests on version 3.11. Thus, it guarantees nothing about correctness or compatibility for versions less than 3.11.

Steps to reproduce the bug

No response

Environment

GitHub actions CI

Additional context

If you only run tests on a single python version, the oldest supported version is probably the best idea. This is what angr does. While there can be compatibility issues on newer versions, they are generally less and more obvious than the reverse. Of course, if you want to be thorough, consider running tests for each supported version.

Related: #365

@twizmwazin twizmwazin added the bug Something isn't working label Apr 10, 2024
@mahaloz
Copy link
Member

mahaloz commented Apr 10, 2024

#367 addresses this PR, but, unfortunately, wouldn't have caught the bug mentioned in #365 because we don't have any code coverage for the IDA code, since we need a private CI for that.

@twizmwazin
Copy link
Collaborator Author

A possible option you could use that may help is using a linter. ruff I believe will report if syntax is invalid for the minimum supported python version, without needing to actually import or run the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants