Syncing creates redundant commits

[VisualEhrmanntraut]

Description

Merging in changes (syncing) creates redundant commits even if there were no changes done to the database. Only changes in the commits are the "last update" message.

Steps to reproduce the bug

Open a BinSync project. Do a "Magic Sync" with "Overwrite" or "Sync All" from a user. Observe that merge commits will be made for every single thing, even if there were no actual changes done.

Environment

Binary Ninja 4.1.5014-dev Personal (349de5a9)
macOS 14.4.1 (23E224)

Additional context

No response

[mahaloz]

Hey @VisualEhrmanntraut would you happen to have a commit in one of your public BinSync projects your referencing? Will be easier to track down if you do.

[VisualEhrmanntraut]

Hey again @mahaloz. ChefKissRE/Adrenaline_24.3.1-amdkmdag.sys@93b58a2 is the first commit when it started spamming when I clicked "Sync All" on the other user (zormeister)

[mahaloz]

Okay, to confirm one other thing, is this exclusively in Magic Sync, or does it also happen in Sync All? The Magic Sync feature is somewhat controversial, and I'm honestly shocked you found it, haha. It's had a bad time in IDA Pro in the past due to some structural syncing.

However, Sync All is supposed to simply sync every change on top of your change (avoiding conflicts).

[VisualEhrmanntraut]

It happens with Magic Sync on “Overwrite” and Sync All. I know they’re supposed to sync everything, but I don’t think it should be making any commits if nothing changed.