Support typedefd types

[alexrp]

Description

If I have e.g. typedef void* HANDLE; in Binary Ninja and I retype a function parameter as HANDLE, BinSync saves it as just void*.

I wonder if there's a way to preserve the typedef in such cases?

Steps to reproduce the bug

1. Create a type: typedef void* HANDLE;.
2. Change a parameter type to HANDLE.
3. Sync the changes.

Environment

Binary Ninja 3.5.4311-dev Personal (ff27871c)

Additional context

No response

[mahaloz]

So this one is actually rather hard and shows how little I use typedefd types. At a fundamental level, typedefed types are different artifact types in BinSync. Currently, we support Struct, which can be a user-defined type, but we have no way to save (or catch) types that are just aliases for primitive types.

To support this we need to support typedef types like we do with things like structs here:
https://github.com/binsync/binsync/blob/main/binsync/data/struct.py

In a bsproj, this can be seen like this:
https://github.com/binsync/example.bsproj/blob/binsync/mahaloz/structs/mahaloz_struct.toml

Proposed changes

1. Create the new artifact type: typedef, add it to list of supported artifacts
2. Add the dumper and loader to state
3. Add a callback to Binja to create it on change

[alexrp]

If I have e.g. typedef void* HANDLE; in Binary Ninja and I retype a function parameter as HANDLE, BinSync saves it as just void*.

Just correcting myself: I don't know where I got this notion from, but BinSync does actually record the parameter as the typedef type name. It's just that the typedef itself isn't synced.

[mahaloz]

@alexrp this is good to know and what should happen in the current setup.