Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n #31

Open
benoitchantre opened this issue Apr 12, 2017 · 5 comments
Open

i18n #31

benoitchantre opened this issue Apr 12, 2017 · 5 comments

Comments

@benoitchantre
Copy link
Contributor

It would be great to internationalize the plugin and to support translations.

I will certainly make a PR.

Ideally, there should be some filters to customize the date and time formats.

@benoitchantre
Copy link
Contributor Author

I'm working on a PR.

At the moment, all (or almost) all strings are translatable.

I don't know if I'll have the time to handle the i18n of date & time.

@benoitchantre
Copy link
Contributor Author

As I have submitted some PR that change strings, I think it is easier to wait a bit for the merge of #33 and #37 to minimize merge conflicts.

@benoitchantre
Copy link
Contributor Author

@billerickson : what is the best plan to follow for this improvement?

  • to rebased the branch on the coding-standards branch before its merge?
  • to wait for the merge of the coding-standards branch?
  • other?

@billerickson
Copy link
Owner

It's probably best to wait until the coding standards branch is merged in, as that made extensive changes throughout the plugin.

@benoitchantre
Copy link
Contributor Author

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants