Weird exception during integration tests

[atari-monk]

Hi @drewburlingame
I have integration test project witch takes my whole app, creates it's instance in xunit fixture and run tests.
When project contains one app/fixture, witch means one test class it works
As soon as i add another test class with (i supposed) independent fixture with app instance, it producess exception, but not with every run. Can you give me any pointer on that ? If apps instances are independant this should not happen, yet it does.

[xUnit.net 00:00:03.00]     Inventory.Modern.CliApp.Tests.StockInsertTests.Test02(cmd: ["item", "ins", "test", "-d", "test", ...]) [FAIL]
  Failed Inventory.Modern.CliApp.Tests.StockInsertTests.Test02(cmd: ["item", "ins", "test", "-d", "test", ...]) [187 ms]
  Error Message:
   System.InvalidOperationException : Stack empty.
  Stack Trace:
     at System.Collections.Generic.Stack`1.ThrowForEmptyStack()
   at System.Collections.Generic.Stack`1.Pop()
   at CommandDotNet.Execution.CancellationHandlers.EndRun(CommandContext ctx) in CommandDotNet/Execution/CancellationHandlers.cs:line 51
   at CommandDotNet.Execution.CancellationMiddleware.<>c.<UseCancellationHandlers>b__0_1(OnRunCompletedEventArgs args) in CommandDotNet/Execution/CancellationMiddleware.cs:line 12
   at CommandDotNet.AppRunner.OnRunCompleted(CommandContext context, ExecutionDelegate next) in CommandDotNet/AppRunner.cs:line 156
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_1.<InvokePipeline>b__3(CommandContext c) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 27
   at CommandDotNet.Execution.CancellationMiddleware.AddCancellationTokens(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/CancellationMiddleware.cs:line 19
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_1.<InvokePipeline>b__3(CommandContext c) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 27
   at CommandDotNet.Diagnostics.TimeDirective.TimeCommand(CommandContext context, ExecutionDelegate next) in CommandDotNet/Diagnostics/TimeDirective.cs:line 27
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_1.<InvokePipeline>b__3(CommandContext c) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 27
   at CommandDotNet.Diagnostics.DebugDirective.AttachDebugger(CommandContext commandContext, ExecutionDelegate next) in CommandDotNet/Diagnostics/DebugDirective.cs:line 33
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17
   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExt   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.<>c__DisplayClass1_0.<InvokePipeline>b__2(CommandContext ctx, ExecutionDelegate next) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 17   at CommandDotNet.Execution.ExecutionMiddlewareExtensions.InvokePipeline(IEnumerable`1 pipeline, CommandContext commandContext) in CommandDotNet/Execution/ExecutionMiddlewareExtensions.cs:line 33   at CommandDotNet.AppRunner.Run(String[] args) in CommandDotNet/AppRunner.cs:line 89
--- End of stack trace from previous location ---   at CommandDotNet.AppRunner.HandleException(Exception ex, CommandContext commandContext) in CommandDotNet/AppRunner.cs:line 185
   at CommandDotNet.AppRunner.Run(String[] args) in CommandDotNet/AppRunner.cs:line 95
   at CommandDotNet.Helper.AppProgRunner`2.Run(String[] args) in c:\kmazanek@gmail.com\Code\commanddotnet-helper\CommandDotNet.Helper\AppProgRunner.cs:line 51
   at CommandDotNet.Helper.AppProgTMethod.Main(String[] args) in c:\kmazanek@gmail.com\Code\commanddotnet-helper\CommandDotNet.Helper\AppProgTMethod.cs:line 20
   at DIHelper.Bootstraper.RunApp(String[] args) in C:\kmazanek@gmail.com\Code\di-helper\DIHelper\Bootstraper\Bootstraper.cs:line 27
   at Inventory.Modern.ConsoleApp.InventoryBootstraper.RunApp(String[] args) in C:\kmazanek@gmail.com\Code\inventory-modern-consoleapp\Inventory.Modern.ConsoleApp\InventoryBootstraper.cs:line 31 
   at Inventory.Modern.CliApp.TestApi.InventoryCliTestApi.RunCmd(IBootstraper booter, String[] cmd) in C:\kmazanek@gmail.com\Code\inventory-modern-consoleapp\Inventory.Modern.CliApp.TestApi\InventoryCliTestApi.cs:line 28
   at Inventory.Modern.CliApp.Tests.StockInsertTests.Test02(String[] cmd) in C:\kmazanek@gmail.com\Code\inventory-modern-consoleapp\Inventory.Modern.CliApp.Tests\Insert\StockInsertTests.cs:line 32

Failed!  - Failed:     1, Passed:     5, Skipped:     0, Total:     6, Duration: 299 ms - Inventory.Modern.CliApp.Tests.dll (net6.0)

[drewburlingame]

Hi @KrzM ,

That sounds like an annoying problem. Given the error message, I do not have nearly enough information to help you troubleshoot and it could be due to a number of different things. Too many for me to throw out wild guesses. I am confident this is not caused by a bug CommandDotNet. We have hundreds of tests creating instances of the same app and haven't encountered this. I've also not encountered it in any other apps I've created with the framework.

I'd suggest either debugging all the tests or adding log statements every time pop is called along with the object id to understand what may be using the same instance and working backward from there.

[atari-monk]

Yes you are right. I switched from Vs code to visual studio to debug.
Static Id incremented in ctor points to xunit fixture beeing one instance, despite promise it's per test class. At least i lean to it for now, still investigating.
--> Well blaming something on framework written and tested better than i care to know is allways stupid idea.
I used Guid to finally see that fixtures are ok.

[drewburlingame]

glad to hear you were able to figure it out.

[atari-monk]

Yeah, thank you, guy like you writing back to users of CommandDotNet and juniors is nice.
It was couple of issues. Database after errors was braking transaction sometimes witch coused errors as it needs to be empty initially.
After moving pc;s, text format (languge of ide changed) of 0.9 versus 0,9 was failing one test and then others. Finally xunit tests in 3 projets needed to have non parallel mode on runner and on classes. Fixture and instance of app was fine.