Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user and organization email address handling #771

Open
realchrisolin opened this issue May 18, 2019 · 6 comments
Open

Improve user and organization email address handling #771

realchrisolin opened this issue May 18, 2019 · 6 comments

Comments

@realchrisolin
Copy link
Contributor

image

image

I can only get the confirmed email in the first image to show in the organization dropdown if I make it my primary email, which is a very unintuitive workflow and feels limiting. Why is an organization email bound to the user's primary account email address? Additionally, there's no (seemingly obvious) way to remove/unlike a confirmed email address from an account.

Lastly, the blurb on the org profile page about the "Email address that registrations through will be sent from" isn't very clear for newer users. Could this verbiage include a tooltip-like preview of what will be sent?

@sethherr
Copy link
Member

First: There isn't a way to remove or unlink a confirmed email address from account. I added Added an issue for that, #773

W/R/T org email: the email is actually just a friendly way of selecting a user - we actually just pull the current active email from the user that is selected. We need to have a user to link to for the creator of each bike, and this is how that is selected.

I can see there being a benefit to being able to specify a non-primary email - but I think it would add a lot of additional complexity, and the same functionality can be achieved (eg by creating a dummy organization user with the email you want register bikes, or by just making the email you want your primary email). I think this is a "won't fix" unless there is something I'm missing?

I agree that the language isn't clear. I struggled to write something that would be clearer. I think something visual is a great idea! It would clarify what is going on. I'm updating the language a little bit (in #772) to try to explain a little better:

Email address organization name bike registrations will be sent from

@realchrisolin
Copy link
Contributor Author

realchrisolin commented May 19, 2019

I'm under the impression that Email address <org name> bike registrations will be sent from means it'll send emails to the bike owners on behalf of whatever email address is selected. It seems natural that users would want the option to have those emails sent from an email address separate from their account email address, but now I'm not so sure that's what's happening based on your reply.

Is that org email only used to link a bike to a user until the owner confirms their account, or is there an outbound email that's also being sent out to the owner that references the org email address? I looked at the changes in #772, but still don't understand what's happening.

@sethherr
Copy link
Member

#772 was just the phrasing update for the help text

The email is referenced in the email that the user is sent. But - we need to confirm that you own an email before you can reference that email in our outbound emails. The fact that you have to have a confirmed account email linked with the email you are sending registrations from is a feature, not a bug.

@realchrisolin
Copy link
Contributor Author

Ah, but I don't believe that's what's happening here. I can only use the primary email address, which is the problem. I should be able to choose a confirmed email address too.

@sethherr
Copy link
Member

See my first comment for explanation of why this would add significant complexity.

I still don't understand why you need this feature, when you can solve this in existing ways:

eg by creating a dummy organization user with the email you want register bikes, or by just making the email you want your primary email

Is there some way that adding this functionality will enable you to do things you currently can't do, or would drive additional users to Bike Index?

@realchrisolin
Copy link
Contributor Author

Your first comment didn't explain why it would add significant complexity, only that it would. My understanding is the complexity is related to the requirement of bikes being linked to a user, which isn't really the issue at hand. The immediate issue here is that outgoing org emails are sent to new users using an account's primary email address. I don't understand how giving user's the ability to send outgoing emails with a confirmed email address (versus the primary email address) would add significant complexity, but I'll take your word for it if you insist.

I still don't understand why you need this feature, when you can solve this in existing ways:

Workarounds are not solutions and I don't personally need this feature. The current workflow doesn't make intuitive sense and took me a minute to figure out and understand. If it gave someone like me a hard time to figure out how to workaround, I expect others less technically inclined would become discouraged and ultimately give up if it affected them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants