You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It should improve performance (look at our Skylight, consider the results from rack-mini-profiler)
It shouldn't reduce passing executed sql queries (currently done in non_serial_matches for the color search), and should instead use correct sql.
It should be restructured to being a service instead of a concern
It should (probably) use private methods - even if this means we have to use send in tests (I feel better about doing this since watching episodes of on writing software well)
Note: it was written as a concern rather than a service originally was so that the methods could be written in a more functionalish style, without having to pass the activerecord collection around - I would like to maintain the funcationalish-ness, but now think passing the collection around is would be better than what we are doing
The text was updated successfully, but these errors were encountered:
The BikeSearchable concern is confusing and not performant.
rack-mini-profiler
)reduce
passing executed sql queries (currently done innon_serial_matches
for the color search), and should instead use correct sql.send
in tests (I feel better about doing this since watching episodes of on writing software well)Note: it was written as a concern rather than a service originally was so that the methods could be written in a more functionalish style, without having to pass the activerecord collection around - I would like to maintain the funcationalish-ness, but now think passing the collection around is would be better than what we are doing
The text was updated successfully, but these errors were encountered: