fix: properly parsing comma-separated list on REST API (#14)

varfish-org · Sep 13, 2023 · 97fdfee · 97fdfee
1 parent aa14b9b
commit 97fdfee
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/cada_prio/predict.py b/cada_prio/predict.py
@@ -66,7 +66,6 @@ def run_prediction(
     # Map gene IDs to HGNC IDs
     genes = []
     for orig_gene in orig_genes or []:
-        print(all_to_hgnc.get(orig_gene))
         if orig_gene in all_to_hgnc:
             genes.append(all_to_hgnc[orig_gene].hgnc_id)
         else:

diff --git a/cada_prio/rest_server.py b/cada_prio/rest_server.py
@@ -59,12 +59,14 @@ class PredictionResult(BaseModel):
 # Register endpoint for the prediction
 @app.get("/predict")
 async def handle_predict(
-    hpo_terms: typing.Annotated[typing.List[str], Query()],
-    genes: typing.Annotated[typing.Optional[typing.List[str]], Query()] = [],
+    hpo_terms: typing.Annotated[str, Query()],
+    genes: typing.Annotated[typing.Optional[str], Query()] = None,
 ):
+    hpo_terms_list = hpo_terms.split(",")
+    genes_list = genes.split(",") if genes else None
     _, sorted_scores = predict.run_prediction(
-        hpo_terms,
-        genes,
+        hpo_terms_list,
+        genes_list,
         GLOBAL_STATIC["all_to_hgnc"],
         GLOBAL_STATIC["graph"],
         GLOBAL_STATIC["model"],