Improve morph support for <template> elements
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes [bigskysoftware#15][] When morphing `<template>` elements, treat the [DocumentFragment][] instances returned from the [HTMLTemplateElement.content][] properties as `morphChildren` methods' `newParent` and `oldParent` variables. That way, descendant nodes can be iterated across the connected-disconnected boundary. [bigskysoftware#15]: bigskysoftware#15 [DocumentFragment]: https://developer.mozilla.org/en-US/docs/Web/API/DocumentFragment [HTMLTemplateElement.content]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLTemplateElement/content
seanpdoyle
force-pushed
the
morph-template-elements
branch
from
f5b02eb
to
dc8816e
Compare
This was referenced Apr 12, 2024
seanpdoyle
commented
Apr 12, 2024
| @@ -110,7 +110,7 @@ var Idiomorph = (function () { | |||
| * @returns {boolean} | |||
| */ | |||
| function ignoreValueOfActiveElement(possibleActiveElement, ctx) { | |||
| return ctx.ignoreActiveValue && possibleActiveElement === document.activeElement; | |||
| return ctx.ignoreActiveValue && possibleActiveElement === document.activeElement && possibleActiveElement !== document.body; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
When morphing
<template>elements, treat the DocumentFragmentinstances returned from the HTMLTemplateElement.content properties
as
morphChildrenmethods'newParentandoldParentvariables.That way, descendant nodes can be iterated across the
connected-disconnected boundary.