Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate and missing code in print version: SERIOUS #122

Open
mvolkmann opened this issue Jan 9, 2024 · 16 comments
Open

duplicate and missing code in print version: SERIOUS #122

mvolkmann opened this issue Jan 9, 2024 · 16 comments

Comments

@mvolkmann
Copy link

mvolkmann commented Jan 9, 2024

This seems like a very serious issue! Often when a code example is split across pages, there is either a missing line of code or several duplicate lines of code. Fortunately I can get the missing code from the online version and write it into my book. I'm currently on page 180 and have encountered this issue many times.

For example, on page 180 the last line should be the following, but it is missing:

<button hx-get="/contacts">

Examples of duplicate code can be found between these pages:
59-60, 64-65, 70-71, 118-119, 133-134, 205-206, 210-211, 254-255, 266-267, 268-269, 290-291, 318-319, 326-327, 331-332

Examples of missing code (typically just one line) can be found between these pages:
129-130, 132-133 (missing line of text, not code), 176-177, 180-181

Perhaps there is a problem in the process that converts the book content into the pages since none of these issues exist in the online version.

@mvolkmann
Copy link
Author

Is anyone actively investigating this issue?

@codetalcott
Copy link
Collaborator

Yes, work is underway on a corrected print version. This will take some time, as it involves waiting for & checking new printed samples.

@codetalcott
Copy link
Collaborator

Hmm, I wonder if this is related to issue #106 : "A few code snippets in part II have horizontal scroll bar
These code blocks are cropped when printed to pdf."

@1cg
Copy link
Contributor

1cg commented Jan 12, 2024

Here is a screenshot for pages 64-65 from the amazon previewer, the look correct to me. Is this the content you are referring to @mvolkmann ?

image

image

@mvolkmann
Copy link
Author

No, that's not what I'm referring to. I mean blocks of code that are split across page boundaries. For example, look at the code labelled 'Inputs and labels for the "new contact" form' that appears across pages 64 and 65 in my printed copy of the book. There are 13 duplicated lines of code.

@1cg
Copy link
Contributor

1cg commented Jan 12, 2024

are these the correct pages:
image
image

Can you post a photo of the pages?

@mvolkmann
Copy link
Author

Here's one example.
IMG_7940

@1cg
Copy link
Contributor

1cg commented Jan 12, 2024

@mvolkmann can you tell me exactly what the error is on that page? Thank you for doing this!

@1cg
Copy link
Contributor

1cg commented Jan 12, 2024

OK I see the issue, the email inputs are repeated twice!

I am looking at the proof and it definitely does not have this, so this is almost certainly an amazon printing issue.

Very sorry about that, I will reach out to them to discuss. Can you take a higher resolution picture of the issue?

@mvolkmann
Copy link
Author

This one is higher resolution. Note that this one of many examples where this happens in the book. I listed all of them in this issue.

IMG_7941

@reubenfirmin
Copy link

reubenfirmin commented Feb 12, 2024

You didn't get them all above :( - for example, pages 85/86 have missing text (rather than code); another example is 226/227, but there are plenty of others.

@dleopold
Copy link

Started reading a hard copy of the book this week and have the same print issues mentioned here - I am noticing many instances of missing text at page transitions.

@1cg
Copy link
Contributor

1cg commented Feb 24, 2024

@reubenfirmin this to me indicates that it is a printing error, @mvolkmann can you confirm pages 85/86 are correct for you?

@dleopold can you confirm that your print issues are the exact same as above?

I spoke with amazon and they do not have a way to show me the current PDF being used to print. However, given that the book was professionally edited the chance this is a PDF error seems very low.

@dleopold
Copy link

I did not check them all, but every error @mvolkmann identified that i did check is present in my printed copy.

@mvolkmann
Copy link
Author

mvolkmann commented Feb 24, 2024 via email

@1cg
Copy link
Contributor

1cg commented Feb 27, 2024

OK, I have ordered another hard copy from amazon and will cross-reference. Seems like a printing issue, given the issue occurs at page boundaries and is inconsistent. Frustrating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants