Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

htmx-2 regression: WebSocket extension no longer sends hx-vals along with calls #10

Open
aral opened this issue Mar 18, 2024 · 1 comment
Open

htmx-2 regression: WebSocket extension no longer sends hx-vals along with calls #10

aral opened this issue Mar 18, 2024 · 1 comment

Comments

@aral
Copy link
Contributor

aral commented Mar 18, 2024

In htmx-1, WebSocket calls sent the data in hx-vals attributes on elements that had ws-send defined on them (see passing test: bigskysoftware/htmx#2416)

In htmx-2, WebSocket calls do not send hx-vals (see failing test: main...aral:htmx-extensions:ws-hx-vals-test).
Renerick added a commit to bigskysoftware/htmx that referenced this issue Mar 18, 2024
@Renerick
expose overrideFormData in internal API, fix ws.js input values proce…
00978fb 
…ssing

bigskysoftware/htmx-extensions#10
Renerick added a commit to bigskysoftware/htmx that referenced this issue Mar 18, 2024
@Renerick
expose overrideFormData in internal API, use it in ws.js for hx-vals …
6d5e03f 
…processing

bigskysoftware/htmx-extensions#10
@Renerick Renerick mentioned this issue Mar 18, 2024
Closed
4 tasks
aral pushed a commit to aral/htmx that referenced this issue Mar 19, 2024
@Renerick @aral
expose overrideFormData in internal API, use it in ws.js for hx-vals …
1320077 
…processing

bigskysoftware/htmx-extensions#10
@aral
Copy link
Contributor Author

aral commented Apr 22, 2024

Can we close this issue now that this has been implement in bigskysoftware/htmx#2418?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aral