Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quesiton about MTFDataset #8

Open
noanti opened this issue Feb 6, 2023 · 1 comment
Open

Quesiton about MTFDataset #8

noanti opened this issue Feb 6, 2023 · 1 comment
Assignees

Comments

@noanti
Copy link

noanti commented Feb 6, 2023

https://github.com/bigscience-workshop/Megatron-DeepSpeed/blob/main/megatron/data/mtf_dataset.py#L34

The MTFDataset class take documents as arguments, but didn't use it(except in assert statement).
I think documents is train/valid/test split index, is it ok to ignore documents?

@thomasw21
Copy link
Member

If I remember correctly, documents are more like "rows". Typically in MTF, it's going to be an input + a target.

As to why we have documents, I think we originally wanted to support permutating randomly but then decided against it, to i'd say it's safe yo remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants