Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Comments should be a Textarea #506

Open
mattcoy-arcticleaf opened this issue Feb 3, 2021 · 7 comments
Open

Order Comments should be a Textarea #506

mattcoy-arcticleaf opened this issue Feb 3, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@mattcoy-arcticleaf
Copy link

Not really an issue, but I strongly feel the Order Comments box should be a textarea element, as opposed to the input it currently is. This would be a much better user experience. I don't think the code change would be difficult.

@lpschz lpschz added the enhancement New feature or request label Feb 10, 2021
@lpschz
Copy link
Contributor

lpschz commented Feb 10, 2021

Hey Matthew, although the change it's small and it makes sense, it could break customizations. However, I will forward it to the Product Team so they can consider it for an enhacement.

@bc-0dp
Copy link
Collaborator

bc-0dp commented Feb 13, 2024

Hi @mattcoy-arcticleaf
This one has been lingering for a bit now, and I was wondering if you managed to sort this out?
It's my opinion that changing this for a specific brand or client would be a trivial operation. As Luis mentions, it's probably best to leave it as is, and then let developers customize the field type itself. YDYT?

@mattcoy-arcticleaf
Copy link
Author

Hi @bc-0dp ,

If making a custom checkout, it would be a simple fix, yes. But most merchants prefer to not use a custom checkout.

Yes, changing the element could affect the CSS appearance for some themes/sites. However, this hasn't stopped you from making changes in the past. I do think this is worth the potential minor appearance breakages.

You would just also need to be very clear that you are rolling this update out and merchants should be aware if they have done customizations to this field.

At the end of the day, it's not 100% necessary, and I do understand if you feel it isn't worth the change.

@bc-0dp
Copy link
Collaborator

bc-0dp commented Feb 13, 2024

I mean it's a great consideration for sure.

Suppose it could be introduced non-breaking by adding the option to choose in the control panel (default: input)

Screenshot 2024-02-13 at 17 10 43

@mattcoy-arcticleaf
Copy link
Author

That would be excellent and make a lot of merchants super happy!

@bc-0dp
Copy link
Collaborator

bc-0dp commented Feb 13, 2024

@bigcommerce/team-checkout for your further considerations

@animesh1987
Copy link
Contributor

@bc-charlesho something we can look at enhancing as an opt in feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants