Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo contents #1

Open
glatard opened this issue Oct 25, 2018 · 0 comments
Open

Repo contents #1

glatard opened this issue Oct 25, 2018 · 0 comments

Comments

@glatard
Copy link
Contributor

glatard commented Oct 25, 2018

Hi @Behzad68, very happy to see that your repo has data and scripts to generate the figures, it looks great! Minor comment: storing binary files such as png and pdf in Git makes the repo bulky. You don't have to do this if you trust your scripts: any contributor could re-generate the figures to create the pdf. I usually add a release of the paper upon submission, and add the current pdf to the release files.

I'll read the paper and provide comments soon, hopefully tonight. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant