Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcargs: 'OTHER_CFLAGS is overwritten even when specified in Fastfile #7

Open
Norod opened this issue Nov 8, 2020 · 3 comments
Open

Comments

@Norod
Copy link

Norod commented Nov 8, 2020

Hello,

Thank you for this plugin.
I'd like to report a bug in which any custom xcargs passed via OTHER_CFLAGS will be overwritten by the string "-fembed-bitcode" regardless of whether or not it's appearing the in related Fastfile argument.
For example, say I have the following specified:
xcargs: 'OTHER_CFLAGS="-DOSCL_EXPORT_REF= -DOSCL_UNUSED_ARG= -DOSCL_IMPORT_REF= -fembed-bitcode"',
I'd expect the plugin to not modify OTHER_CFLAGS, but it will replace it, leaving only "-fembed-bitcode" and thus changing the intended compilation code.

Regards,
Doron

@bielikb
Copy link
Owner

bielikb commented Nov 8, 2020

Oh nice catch! Thanks for reporting this. Ill fix this issue in following days

@vg-identance
Copy link

Any update on this?

@1ec5
Copy link

1ec5 commented Apr 5, 2024

As a workaround, you can disable Bitcode by setting enable_bitcode: false when invoking create_xcframework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants