Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Literal vs "Query" name #8

Open
adelavega opened this issue Dec 5, 2022 · 2 comments
Open

Literal vs "Query" name #8

adelavega opened this issue Dec 5, 2022 · 2 comments
Labels
question Further information is requested

Comments

@adelavega
Copy link
Collaborator

ANCPBids uses "literal" name (e.g. ses) whereas pybids uses the Display name (e.g: session)
@adelavega adelavega changed the title Literal vs Display names Literal vs Display names vs "Query" name Dec 5, 2022
@adelavega
Copy link
Collaborator Author

See also acquisition:

https://github.com/bids-standard/bids-schema/blob/d0c3ff34c4c2cf919d565099fbd4a5b8235c5d88/versions/latest/objects/entities.yaml#L6

@adelavega adelavega changed the title Literal vs Display names vs "Query" name Literal vs "Query" name Dec 5, 2022
@erdalkaraca
Copy link
Collaborator

the generated enums also have a "name" attribute which denote the "long form" of the entity keys... I was not sure what to use where

there is also a parameter to return the long form when querying entities:
https://github.com/ANCPLabOldenburg/ancp-bids/blob/31f5d999d09382078286afd44bdfa030bbecc079/ancpbids/query.py#L311

@erdalkaraca erdalkaraca added the question Further information is requested label Dec 7, 2022
@adelavega adelavega mentioned this issue Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erdalkaraca @adelavega