Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add separate dev and prod configs #19

Open
frankiesardo opened this issue Dec 19, 2019 · 0 comments
Open

Please add separate dev and prod configs #19

frankiesardo opened this issue Dec 19, 2019 · 0 comments
Assignees

Comments

@frankiesardo
Copy link

Hi @bhauman

Thanks for providing this template, it's really useful to get up to speed with fighweel-main. However we find it really hard to extend since the min task basically takes the dev configuration and turns the advanced optimisation on.

Once you start to add basic things like closure-defines {goog.DEBUG false} you really need two separate configs, and once you have two configs you start to encounter other problems like differently named .js files and once you fix that via output-dir you break other things like auto-testing.

To summarise, it would be nice to have a full production-ready template that is easy to extend 🙏

Thank you!

@bhauman bhauman self-assigned this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants