Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API Property - independence_year #50

Open
sthiepaan opened this issue Oct 3, 2020 · 8 comments · May be fixed by #67
Open

Add new API Property - independence_year #50

sthiepaan opened this issue Oct 3, 2020 · 8 comments · May be fixed by #67
Assignees

Comments

@sthiepaan
Copy link
Collaborator

After short introduction in #32 we decided to extend this package with independence_year Property:

  • independence_year Property is a Number of year when country became independent
  • For countries that have no year available it should be set to 0, null or year when country was settled (TBD)

After adding new property, each Country {Object} should contain:

{
  "country": "poland",
  "capital": "warsaw",
  "currency": "zloty",
  "native_language": ["polish"],
  "famous_for": "pierogi and potatoes",
  "phone_code": "+48",
  "flag": "https://flagpedia.net/data/flags/h80/pl.png",
  "drive_direction": "right",
  // NEW DATA
  "independence_year": 1918
},

Additionally there will be new method to use that data:

  • getCountriesByIndependenceYear(independenceYear)
  • getCountriesByIndependenceYearRange(fromYear, toYear)
@Koushith
Copy link

Koushith commented Oct 3, 2020

Hii, I'm a newbie developer. can you please assign this to me?

@bhatvikrant
Copy link
Owner

@sthiepaan will you be taking up this issue? or should I assign it to @Koushith ?

@sthiepaan
Copy link
Collaborator Author

@Koushith can take it if all is clear to him 😉

@bhatvikrant
Copy link
Owner

I think the task is fairly simple tho, do you understand it fully @Koushith?
If yes, then you can pick it up bud and I'll assign it to you.

@jav7zaid
Copy link
Contributor

jav7zaid commented Oct 5, 2020

@bhatvikrant let me know if can take this as well. @Koushith are you on it ?

@Koushith
Copy link

Koushith commented Oct 5, 2020

@bhatvikrant yeah. I'm working on it. 👍

@sthiepaan
Copy link
Collaborator Author

What is the status of your work so far @Koushith? 😉

@sthiepaan sthiepaan assigned sthiepaan and unassigned Koushith Oct 31, 2020
@sthiepaan
Copy link
Collaborator Author

Since there is no response from @Koushith, I will take care of that Issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants