Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Angular 6 #141

Closed
2 tasks
BovineEnthusiast opened this issue Jun 4, 2018 · 5 comments
Closed
2 tasks

Does not work with Angular 6 #141

BovineEnthusiast opened this issue Jun 4, 2018 · 5 comments

Comments

@BovineEnthusiast
Copy link
Contributor

  • I'm submitting a ...

    • [x ] bug report
    • feature request
    • support request => Please do not submit support request here, see note at the top of this template.
  • Do you want to request a feature or report a bug?

Bug

  • What is the current behavior?

Currently, the images wrap onto new lines instead of being hidden inside the carousel. This code was functioning before we upgraded to Ng6 and thus from angular2-drag-scroll to ngx-drag-scroll. I've looked at the latest project, and it doesn't seem like the directives changed.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem you can use the demo site as an example or via https://plnkr.co
<div
    *ngIf="soloView"
    class="mobile-photos-container"
    drag-scroll
    fxShow
    fxHide.gt-sm>
    <img
        *ngFor="let photo of photos"
        src="{{photo?.url}}"
        alt="Item Picture">
</div>

Results in the following:

screen shot 2018-06-04 at 3 18 00 pm

  • Please tell us about your environment:

    Latest ngx-drag-scroll, Angular 6, and latest Chrome.

@BovineEnthusiast
Copy link
Contributor Author

Please let me know if you'd like me to try anything out or test.

@bfwg
Copy link
Owner

bfwg commented Jun 5, 2018

Hi @MrSnappingTurtle , can you try to test without the flexLayout attributes and user dragScroll instead of drag-scroll?

<div
    *ngIf="soloView"
    class="mobile-photos-container"
    dragScroll>
    <img
        *ngFor="let photo of photos"
        src="{{photo?.url}}"
        alt="Item Picture">
</div>

@BovineEnthusiast
Copy link
Contributor Author

I'll try it out later today and will let you know.

@BovineEnthusiast
Copy link
Contributor Author

Ah, it's dragScroll now. Didn't notice that changed when I looked at the npm page, sorry. All works now.

Thanks for your help! :)

@bfwg
Copy link
Owner

bfwg commented Jun 8, 2018

No problem. Glad I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants