Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"//" in import declarations are incorrectly recognized as comments #81

Open
infmagic2047 opened this issue Apr 8, 2024 · 0 comments · May be fixed by #82
Open

"//" in import declarations are incorrectly recognized as comments #81

infmagic2047 opened this issue Apr 8, 2024 · 0 comments · May be fixed by #82

Comments

@infmagic2047
Copy link

Consider this piece of shader code:

#import "embedded://path/to/shader.wgsl"::foo

Currently, naga_oil recognizes the "//" part of the import path as comments and replaces the line with #import "embedded:, so this import declaration becomes invalid. This breaks shader import in Bevy with asset sources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't strip quoted comments robtfm/naga_oil
1 participant
@infmagic2047