Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing shader def literal should report appropriate error #57

Open
robtfm opened this issue Sep 18, 2023 · 0 comments
Open

missing shader def literal should report appropriate error #57

robtfm opened this issue Sep 18, 2023 · 0 comments

Comments

@robtfm
Copy link
Collaborator

robtfm commented Sep 18, 2023

currently trying to use a shader def literal when the def isn't defined gives a strange error:

error: expected expression, found '#'
  ┌─ crates/bevy_pbr/src/render/pbr_bindings.wgsl:6:101
  │
6 │ var<uniform> materials: array<bevy_pbr::pbr_types::StandardMaterial, #{MATERIAL_BUFFER_BATCH_SIZE}u>;
  │                                                                                                     ^ expected expression
  │
  = expected expression, found '#'

it should instead return a specific error pointing out the missing def.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant