Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bevy Example panicked #1123

Closed
lomirus opened this issue Mar 20, 2024 · 9 comments
Closed

Bevy Example panicked #1123

lomirus opened this issue Mar 20, 2024 · 9 comments
Labels
A-Examples C-Bug A problem with the code that runs the site

Comments

@lomirus
Copy link

lomirus commented Mar 20, 2024

This page panicked on Chrome 123.0.6312.59.

QQ截图20240321000340
@rparrett
Copy link
Contributor

rparrett commented Mar 20, 2024 •
edited

The underlying bug was fixed by bevyengine/bevy#12051 and released in Bevy 0.13.1, but there is an issue with the deployment of examples build with 0.13.1 to the website that is being worked on.

edit: Oops, linked wrong PR.

@rparrett rparrett added C-Bug A problem with the code that runs the site A-Examples labels Mar 20, 2024
@rparrett rparrett mentioned this issue Mar 23, 2024
Closed
@mockersf
Copy link
Member

this will be fixed by rebuilding the examples after #1124 has been merged

@BD103
Copy link
Member

BD103 commented Mar 25, 2024

Keep an eye on https://github.com/bevyengine/bevy-website/actions/runs/8426552947, which should finish in about 2 hours and fix the problem.

@lomirus
Copy link
Author

lomirus commented Mar 26, 2024 •
edited

This problem still exists:

image

@BD103
Copy link
Member

BD103 commented Mar 26, 2024

Could you please try clearing your browser cache and refreshing the page?

@lomirus
Copy link
Author

lomirus commented Mar 26, 2024 •
edited

I have enabled the "Disable cache" option in the Network tab and tried the "Reload Cache and Hard Reload", but it still reproduced.

The returned wasm_example_bg.wasm seems the latest.

image

@rparrett
Copy link
Contributor

It looks like the other examples with custom shaders are now working after the deployment, but "mesh2d manual" specifically is still broken. This could be a separate issue that was not fixed in 0.13.1.

https://bevyengine.org/examples/2D%20Rendering/mesh2d-manual/

@mockersf mockersf mentioned this issue Mar 27, 2024
Merged
@mockersf
Copy link
Member

that example was broken for another additional reason than the other ones, should be fixed by bevyengine/bevy#12753

github-merge-queue bot pushed a commit to bevyengine/bevy that referenced this issue Mar 28, 2024
@mockersf
fix example mesh2d_manual in wasm/webgl2 (#12753)
ece6249 
# Objective

- Example `mesh2d_manual` crashes in wasm/webgl2, as reported in
bevyengine/bevy-website#1123 (comment)
```
wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 1, Gl)>`
    In a set_push_constant command
    Provided push constant is for stage(s) ShaderStages(VERTEX), however the pipeline layout has no push constant range for the stage(s) ShaderStages(VERTEX)
```

## Solution

- Properly declare the push constant as in
https://github.com/bevyengine/bevy/blob/4508077297a92295d8b6fb6b07a63b547deac1e0/crates/bevy_sprite/src/mesh2d/mesh.rs#L514-L524
mockersf added a commit to bevyengine/bevy that referenced this issue Apr 1, 2024
@mockersf
fix example mesh2d_manual in wasm/webgl2 (#12753)
ba1aca3 
# Objective

- Example `mesh2d_manual` crashes in wasm/webgl2, as reported in
bevyengine/bevy-website#1123 (comment)
```
wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 1, Gl)>`
    In a set_push_constant command
    Provided push constant is for stage(s) ShaderStages(VERTEX), however the pipeline layout has no push constant range for the stage(s) ShaderStages(VERTEX)
```

## Solution

- Properly declare the push constant as in
https://github.com/bevyengine/bevy/blob/4508077297a92295d8b6fb6b07a63b547deac1e0/crates/bevy_sprite/src/mesh2d/mesh.rs#L514-L524
@mockersf
Copy link
Member

mockersf commented Apr 5, 2024

fixed now with the 0.13.2 release

@mockersf mockersf closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Examples C-Bug A problem with the code that runs the site
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rparrett @mockersf @lomirus @BD103