Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent link color for Bevy supporters section #1099

Open
BD103 opened this issue Mar 12, 2024 · 2 comments
Open

Consistent link color for Bevy supporters section #1099

BD103 opened this issue Mar 12, 2024 · 2 comments
Labels
A-Home C-Webdev S-Needs-Design Needs some thought about how this could be solved

Comments

@BD103
Copy link
Member

BD103 commented Mar 12, 2024

Edit: The links the the donation section on the home page use the browser-default color, instead of the Bevy themed one.

The link "The Quick Start Guide" is rgb(124, 144, 255), while the link "abledbody" is rgb(140, 140, 255). Should these be made the same color, since they are both links?

(Also weirdly enough the blue of "abledbody" shows up as a dark blue on my phone, likely due to an Apple shader. This is what helped me catch the different colors.)

image image
@BD103 BD103 added the A-Home label Mar 12, 2024
@BD103
Copy link
Member Author

BD103 commented Mar 12, 2024

Turns out "abledbody" is not styled with a color at all, so it uses the browser's default. I believe it is because the link is not within a .media-content class.

@TrialDragon, what are your thoughts on this? Should the donation section be wrapped in .media-content, or should the SCSS be edited? I think we should at least set the default for all <a> tags...

@TrialDragon
Copy link
Member

TrialDragon commented Mar 12, 2024

Hmm, it feels like it'd maybe make more sense for the media content stuff to be the default, but maybe it was put under a class due to css specificity issues. For now, we should wrap the appropriate things that are missing the class with the .media_content class, but also look into moving those values out, and maybe into the html element css or somewhere just as universal by default.

@alice-i-cecile alice-i-cecile added C-Webdev S-Needs-Design Needs some thought about how this could be solved labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Home C-Webdev S-Needs-Design Needs some thought about how this could be solved
Projects
None yet
Development

No branches or pull requests

3 participants