Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12 news post dead link to CompressedImageSaver #1049

Open
GitGhillie opened this issue Feb 22, 2024 · 6 comments
Open

0.12 news post dead link to CompressedImageSaver #1049

GitGhillie opened this issue Feb 22, 2024 · 6 comments
Labels
A-News C-Correction A typo or factual issue in what we've written S-Needs-Design Needs some thought about how this could be solved

Comments

@GitGhillie
Copy link

Dunno if this is the right spot for this, but I was looking at https://bevyengine.org/news/bevy-0-12/#compressedimagesaver and when I pressed the link to CompressedImageSaver (https://docs.rs/bevy/0.12.0/bevy/render/texture/struct.CompressedImageSaver.html) I got "The requested resource does not exist". And I can't seem to find what happened to CompressedImageSaver.

@alice-i-cecile alice-i-cecile added A-News C-Correction A typo or factual issue in what we've written labels Feb 22, 2024
@TrialDragon TrialDragon added the S-Needs-Investigation We need to figure out what's going wrong label Feb 22, 2024
@TrialDragon
Copy link
Member

It appears CompressedImageSaver does exist, but isn't being recorded in the docs at all? That link is supposed to be valid.

@alice-i-cecile
Copy link
Member

I bet it's not included in the default features, so it's not showing up on docs.rs.

@TrialDragon
Copy link
Member

It would appear so. It's under basis-universal which isn't a default feature. Is there any way to make these features visible for users? Like something to enable client-side on docs.rs, or maybe something we have to do on our end?

@TrialDragon TrialDragon added S-Needs-Design Needs some thought about how this could be solved and removed S-Needs-Investigation We need to figure out what's going wrong labels Feb 22, 2024
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Feb 22, 2024

google/mundane#21

Looks like this is the field we need. IIRC dev-docs is already built with all features: see https://dev-docs.bevyengine.org/bevy/render/texture/struct.CompressedImageSaver.html

Further information: https://docs.rs/about/builds#detecting-docsrs

@TrialDragon
Copy link
Member

Will this be solved by bevyengine/bevy#12366 when the next Bevy version releases on crates.io?

@alice-i-cecile
Copy link
Member

No, it won't: that will only resolve similar problems for future releases. I think that this is probably not worth spending more effort to fix for an old news post though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-News C-Correction A typo or factual issue in what we've written S-Needs-Design Needs some thought about how this could be solved
Projects
None yet
Development

No branches or pull requests

3 participants