Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating assets is slow #358

Open
d-bucur opened this issue Aug 22, 2023 · 2 comments
Open

Generating assets is slow #358

d-bucur opened this issue Aug 22, 2023 · 2 comments

Comments

@d-bucur
Copy link
Contributor

d-bucur commented Aug 22, 2023

Right now the job takes more than 5 minutes generating metadata. Since every asset is filled sequentially it will only get worse linearly as more assets are added. This is especially noticeable when developing locally, but might also become an issue in GitHub Actions as the quotas are reached.

On a full site redeploy for example 8m 20s out of 11m 20s are spent in the asset phase, out of which 3m are compile time and the 5m 20s are running the generation.

The proposed solution is to parallelize metadata requests as much as possible while trying to not hit service throttling limits.

Edit: my bad, this should probably have been opened in the bevy-website repository.

@mockersf
Copy link
Member

I think we should prefer link to crates.io instead of to the git repository, as metadata there are much more easier to get. Getting metadata will always be slow, and at some point we'll reach the maximum possible...

Currently there are 218 links to GitHub and 50 links to crates.io.

@d-bucur
Copy link
Contributor Author

d-bucur commented Aug 23, 2023

That makes sense. I mostly opened this as I thought I would have to regenerate it for every visual change to the assets page, and that was scary. But you only have to do it once when you set it up so it's not that big of an issue.

Still maybe a parameter to skip metadata could be useful to get fast data for development. Github and Gitlab are skipped anyway if the token is not present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants