Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide recommended image dimensions #188

Open
djeedai opened this issue Mar 17, 2022 · 2 comments
Open

Provide recommended image dimensions #188

djeedai opened this issue Mar 17, 2022 · 2 comments

Comments

@djeedai
Copy link
Contributor

djeedai commented Mar 17, 2022

The current image space on the website is 83.7 x 128 px. Most images are way larger than that. On the other hand, the current website layout is not very good and could be improved, which could lead to displaying a larger preview image in the future (and hopefully better the largest allowed description text, which is currently cropped; see #159). I think it would be nice to set expectations and provide a recommended image dimension, the largest we think we will reasonably ever display in the future for any asset.

For the sake of discussion I'd propose something like 256 x 256 px, which is about 2x the current display so would allow crisp rendering on high DPI monitors, and is square so we can future proof it with respect to various current and future layouts of the website. We can consider larger sizes too, but being mindful some images are animated (GIF) so disk size will grow quickly.

@mockersf
Copy link
Member

but being mindful some images are animated (GIF) so disk size will grow quickly.

We should also suggest a limit in file size. The biggest gif is currently 4.0MB, with the whole repo at 17MB, and the page load at 16.7MB

@rparrett
Copy link
Contributor

rparrett commented Jan 20, 2023

We're displaying these with a constant aspect ratio now so it would be a bit easier to recommend a size.

It seems like something like 400x225 might be about right / large enough for all the mobile displays that chrome simulates by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants