-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: merge choose-menu
and choose-option
into choose
#188
Comments
Still need to imlpement: - `--linger` - `--confirm-default=no` - `--confirm-input` ...and to make them consistent between ask, confirm, choose. This removes `--filter` from choose, as it is better facilitated by the new `--default(s)-fuzzy=` /close #188
choose-menu
and choose-option
into choose
So this was done during my trip to Bali in April, and I'm now fixing up the tests. Updates were posted to the discord server. One issue is that I removed filter functionality in favour of a new As such, after some prototyping and discussion with @molleweide I'll go with the last option in this brainstorm below, which introduces the idea of preferences:
|
…ults, which unfortunately was left behind on my mac mini when I did the rebase on my macbook # Conflicts: # commands/ask # commands/choose-menu # commands/confirm # commands/setup-git # commands/sparse-vault Also: - implement better timeout and error handling, no need for a delay anymore, and now commentary visible in linger - update callers accordingly, also update `dorothy` to remove unnecessary indentation, update `echo-lines` to remove typo in comment - add tests for the `echo-trim-colors` new handling of inline Still need to: - `choose`: - update tests for rewrite - fix duplicate `DEFAULTS` in choose (probably a long-standing regression) - support multiple default matches in `--no-multi` (as done by `echo-checksum`) by adding the concept of preferences - see details at #188 (comment) - add linger and timeout tests to `ask`, `choose`, `confirm`
choose-menu returns indexes, choose-option supports filters. They should be the same command now, which would offer a better experience around timeouts and filters. The different functionality should just be via a choose --index option or so.
The text was updated successfully, but these errors were encountered: