Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest PR changes into gh-pages #168

Open
5 of 6 tasks
onebree opened this issue Feb 16, 2016 · 14 comments
Open
5 of 6 tasks

Merge latest PR changes into gh-pages #168

onebree opened this issue Feb 16, 2016 · 14 comments
Labels

Comments

@onebree
Copy link
Contributor

onebree commented Feb 16, 2016

After the move to v2.0, I merged some PRs into master, not realizing that the bulk of the content is not on the gh-pages branch.

  • Typo "Here a" #165 - "Here a" typo
  • Manually merge other PRs into gh-pages branch (not currently selected)
  • Change default branch from master to gh-pages (@andreareginato)
    • Add blurb in "Contributing" about new default branch (Add blurb in CONTRIBUTING #174)
    • If we make gh-pages the default, do we even need a "master" branch?
  • Merge changes from master into (and before) gh-pages
@onebree onebree added the todo label Feb 16, 2016
@onebree onebree self-assigned this Feb 16, 2016
@vtorves
Copy link
Contributor

vtorves commented Feb 17, 2016

@onebree solved a first item. #169

@vtorves
Copy link
Contributor

vtorves commented Feb 18, 2016

that way you think to solve this?

  • Manually merge other PRs into gh-pages branch (not currently selected)

@onebree
Copy link
Contributor Author

onebree commented Feb 18, 2016

@vtorves I need to review your pull request. I appreciate what you've done so far to help us out in this transition.

As far as the second task, that is something I would rather a maintainer to complete. There are likely to be merge conflicts because of the new site.

@onebree
Copy link
Contributor Author

onebree commented Feb 19, 2016

@andreareginato any thoughts on changing the default branch to gh-pages? I mean, do we even need master? Just curious. The only experience I have with GH Pages is when it comes from username.github.io, in which master is the only branch. (Personal, not project pages)

@dankohn
Copy link
Collaborator

dankohn commented Feb 19, 2016

I recommend this proposed change.

Dan Kohn mailto:dan@dankohn.com
tel:+1-415-233-1000

On Fri, Feb 19, 2016 at 8:19 AM, Hunter Stevens notifications@github.com
wrote:

@andreareginato https://github.com/andreareginato any thoughts on
changing the default branch to gh-pages? I mean, do we even need master?
Just curious. The only experience I have with GH Pages is when it comes
from username.github.io, in which master is the only branch. (Personal,
not project pages)


Reply to this email directly or view it on GitHub
#168 (comment)
.

@andreareginato
Copy link
Collaborator

Simplification should be the driver. +1

@onebree
Copy link
Contributor Author

onebree commented Feb 20, 2016

@andreareginato I do not have permissions to change the repo's settings -- this is something that you need to do. I can only delete or create branches. Not change which is default

@andreareginato
Copy link
Collaborator

@onebree you and @akz92 are now admin. Let me know if you have the right permissions.

@onebree
Copy link
Contributor Author

onebree commented Feb 23, 2016

@benoittgt I am assigning this issue to you. Here is how I would go about things:

  1. Fork lelylan/betterspecs off of gh-pages branch
  2. Checkout a new branch prs-in-gh-pages
  3. For the PRs: Fix 'RSpec' capitalization #135, Update books.html #137, Fix "Easy to read matchers" index entry to match section title #138, Fix Spanish and French versions of 'guard' section #164
    1. Create a remote for the author branch on the PR.
    2. git merge --no-commit <remote> <branch>
    3. Review the changes, fix any merge conflicts, etc
    4. Create 1 commit per PR fixed
  4. Submit 1 PR against gh-pages, containing all these changes, include the main comment: Closes #135, closes #137, closes #138, closes #164
  5. Another person can review the changes to make sure everything is good, then submit the PR.

@onebree
Copy link
Contributor Author

onebree commented Feb 25, 2016

@benoittgt can you work on the last 2 tasks listed in this issue?

  • Add blurb in CONTRIBUTING about choosing the gh-pages branch. Even though it is currently the default, some people may still try to choose master.
  • Research whether we need the master branch at all.
    • If we do not need it, I will take it from there -- I want to make sure all the help from everyone is not lost, and that the commit history is maintained.
    • If we do need a master branch, then its current state should be copied to a new branch heroku. From there, I will then clear out everything in master, except for READMEs, etc.

@benoittgt
Copy link
Collaborator

For the gh-pages branch this for me not a problem expect the thing we should have a README. :)

@onebree
Copy link
Contributor Author

onebree commented Feb 29, 2016

@benoittgt of course there should be a README. But did you research whether a project-page/repo can live without a "master"-named branch?

@benoittgt
Copy link
Collaborator

@onebree I did some research about "master" branch but didn't found something relevant. On Pro Git 2nd Edition by Scott Chacon and Ben Straub we can read this... but that's all.

capture d ecran 2016-03-01 a 09 50 41

@onebree
Copy link
Contributor Author

onebree commented Mar 1, 2016

@benoittgt Alright -- I will look into doing a quick merge this week, so gh-pages contains all master commits.

@benoittgt benoittgt removed their assignment Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants