馃挕 RFC: Replace PegJs with Peggy #120
Assignees
Comments
isaiahdahl
added a commit
that referenced
this issue
Mar 16, 2022
martijnversluis
pushed a commit
that referenced
this issue
Mar 23, 2022
martijnversluis
pushed a commit
that referenced
this issue
Oct 20, 2022
martijnversluis
pushed a commit
that referenced
this issue
Oct 20, 2022
martijnversluis
pushed a commit
that referenced
this issue
Oct 28, 2022
isaiahdahl
added a commit
that referenced
this issue
Nov 9, 2022
* Improve existing tests for chord symbols and numerics * Implement numeral chords, keys and notes Resolves #20 * Transpose following Enharmonic Rules & Normalize Chord Suffix' (#48) Co-authored-by: Isaiah Dahl <isaiahdahl@me.com> * Implement Song#setCapo and Song#setKey (#112) `setCapo` changes the song capo, both in `metadata` and the `capo` directive. `setKey` changes the song key in `metadata` and the `key` directive, and transposes all chords according to the distance between the current key and the new key. Co-authored-by: isaiah dahl <isaiahdahl@me.com> * Implement getCapos() and getKeys() (#114) * Implement getCapos() and getKeys() `getCapos(key)` returns available capos for a certain key. `getKeys(key)` returns available keys to transpose to. Resolves #22 * return self in the list of keys, fixes other tests Co-authored-by: isaiah dahl <isaiahdahl@me.com> * fixes #120 replace pegjs with peggy (#121) * Migrate to TypeScript/Parcel setup (#125) * Move get_capos and get_keys tests to test folder * Migrate to TypeScript/Parcel setup * Include types in package * Use whitelist for package contents * Add browserify as dependency * tweak type for note so that number test don't fail * adjust some enharmonics * update tests referening the enharmonics changes * bass notes cannot be minor (#225) * Fixes #226 Normalize Tweaks (#227) * consolidate normalizing logic, normalize bass from root, normalzie bass from relative major of minor root * fix grammar in doc * fixup! 6fcad88 Co-authored-by: Martijn Versluis <martijnversluis@users.noreply.github.com> * Initial PegJS version for parsing chords over words (#272) * Initial PegJS version for parsing chords over words * Pull chord grammar to separate grammar file * add tests for chords over words parser * chords over words grammar tweaks * add some more complicated chords over words tests with rhythm chords and chords only lines * WIP improvements to fix tests * Fix chords-only lines * Support inline metadata Co-authored-by: isaiah dahl <isaiahdahl@me.com> * Use chord grammar for `Chord.parse` (#309) * Gh 215 allow overriding metadata (#315) * Add type declarations to Metadata class * Add `Metadata.merge()` function It returns a new Metadata object where metadata is merged with the supplied metadata. Resolves #215 * Remove unnecessary .parcelrc file * Fix CI * fix dependencies * Remove unused args in template formatting Co-authored-by: Isaiah Dahl <isaiahdahl@me.com>
martijnversluis
added a commit
that referenced
this issue
Nov 10, 2022
* Improve existing tests for chord symbols and numerics * Implement numeral chords, keys and notes Resolves #20 * Transpose following Enharmonic Rules & Normalize Chord Suffix' (#48) Co-authored-by: Isaiah Dahl <isaiahdahl@me.com> * Implement Song#setCapo and Song#setKey (#112) `setCapo` changes the song capo, both in `metadata` and the `capo` directive. `setKey` changes the song key in `metadata` and the `key` directive, and transposes all chords according to the distance between the current key and the new key. Co-authored-by: isaiah dahl <isaiahdahl@me.com> * Implement getCapos() and getKeys() (#114) * Implement getCapos() and getKeys() `getCapos(key)` returns available capos for a certain key. `getKeys(key)` returns available keys to transpose to. Resolves #22 * return self in the list of keys, fixes other tests Co-authored-by: isaiah dahl <isaiahdahl@me.com> * fixes #120 replace pegjs with peggy (#121) * Migrate to TypeScript/Parcel setup (#125) * Move get_capos and get_keys tests to test folder * Migrate to TypeScript/Parcel setup * Include types in package * Use whitelist for package contents * Add browserify as dependency * tweak type for note so that number test don't fail * adjust some enharmonics * update tests referening the enharmonics changes * bass notes cannot be minor (#225) * Fixes #226 Normalize Tweaks (#227) * consolidate normalizing logic, normalize bass from root, normalzie bass from relative major of minor root * fix grammar in doc * fixup! 6fcad88 Co-authored-by: Martijn Versluis <martijnversluis@users.noreply.github.com> * Initial PegJS version for parsing chords over words (#272) * Initial PegJS version for parsing chords over words * Pull chord grammar to separate grammar file * add tests for chords over words parser * chords over words grammar tweaks * add some more complicated chords over words tests with rhythm chords and chords only lines * WIP improvements to fix tests * Fix chords-only lines * Support inline metadata Co-authored-by: isaiah dahl <isaiahdahl@me.com> * Use chord grammar for `Chord.parse` (#309) * Gh 215 allow overriding metadata (#315) * Add type declarations to Metadata class * Add `Metadata.merge()` function It returns a new Metadata object where metadata is merged with the supplied metadata. Resolves #215 * Remove unnecessary .parcelrc file * Fix CI * fix dependencies * Remove unused args in template formatting Co-authored-by: Isaiah Dahl <isaiahdahl@me.com>
martijnversluis
added a commit
that referenced
this issue
Nov 10, 2022
* Bump @babel/core from 7.19.3 to 7.19.6 (#713) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.19.3 to 7.19.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.19.6/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/node from 18.11.2 to 18.11.7 (#722) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.11.2 to 18.11.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eslint from 8.25.0 to 8.26.0 (#717) Bumps [eslint](https://github.com/eslint/eslint) from 8.25.0 to 8.26.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.25.0...v8.26.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update upstream (#714) * Improve existing tests for chord symbols and numerics * Implement numeral chords, keys and notes Resolves #20 * Transpose following Enharmonic Rules & Normalize Chord Suffix' (#48) Co-authored-by: Isaiah Dahl <isaiahdahl@me.com> * Implement Song#setCapo and Song#setKey (#112) `setCapo` changes the song capo, both in `metadata` and the `capo` directive. `setKey` changes the song key in `metadata` and the `key` directive, and transposes all chords according to the distance between the current key and the new key. Co-authored-by: isaiah dahl <isaiahdahl@me.com> * Implement getCapos() and getKeys() (#114) * Implement getCapos() and getKeys() `getCapos(key)` returns available capos for a certain key. `getKeys(key)` returns available keys to transpose to. Resolves #22 * return self in the list of keys, fixes other tests Co-authored-by: isaiah dahl <isaiahdahl@me.com> * fixes #120 replace pegjs with peggy (#121) * Migrate to TypeScript/Parcel setup (#125) * Move get_capos and get_keys tests to test folder * Migrate to TypeScript/Parcel setup * Include types in package * Use whitelist for package contents * Add browserify as dependency * tweak type for note so that number test don't fail * adjust some enharmonics * update tests referening the enharmonics changes * bass notes cannot be minor (#225) * Fixes #226 Normalize Tweaks (#227) * consolidate normalizing logic, normalize bass from root, normalzie bass from relative major of minor root * fix grammar in doc * fixup! 6fcad88 Co-authored-by: Martijn Versluis <martijnversluis@users.noreply.github.com> * Initial PegJS version for parsing chords over words (#272) * Initial PegJS version for parsing chords over words * Pull chord grammar to separate grammar file * add tests for chords over words parser * chords over words grammar tweaks * add some more complicated chords over words tests with rhythm chords and chords only lines * WIP improvements to fix tests * Fix chords-only lines * Support inline metadata Co-authored-by: isaiah dahl <isaiahdahl@me.com> * Use chord grammar for `Chord.parse` (#309) * Gh 215 allow overriding metadata (#315) * Add type declarations to Metadata class * Add `Metadata.merge()` function It returns a new Metadata object where metadata is merged with the supplied metadata. Resolves #215 * Remove unnecessary .parcelrc file * Fix CI * fix dependencies * Remove unused args in template formatting Co-authored-by: Isaiah Dahl <isaiahdahl@me.com> * Bump @typescript-eslint/eslint-plugin from 5.41.0 to 5.42.0 (martijnversluis#727) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.41.0 to 5.42.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.42.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/node from 18.11.7 to 18.11.9 (martijnversluis#726) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.11.7 to 18.11.9. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add all missing types (#723) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Martijn Versluis <martijnversluis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background & Motivation
PegJS is no longer maintained, someone took it over and replaced it with PeggyJs. Which is fundamentally a fork of PegJS that has now moved forward.
pegjs/pegjs#639
If we want an ESM build we need to switch to peggy because it supports a --format es in the build script.
https://peggyjs.org/development/
Proposed Solution
yarn install peggy
The text was updated successfully, but these errors were encountered: