Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Suggestion: on mobile => platform.name = 'Chrome Mobile', replace with just 'Chrome' #127

Open
alx-so opened this issue Apr 14, 2017 · 3 comments
Labels

Comments

@alx-so
Copy link

alx-so commented Apr 14, 2017

In my case I just need browser name to make DOM manipulations. On mobile you have to do additional work to split it to get just 'Chrome' string.

Suggestion:

  • always return single browser name 'IE, Firefox, Chrome, Safari' etc.
  • add new boolean property platform.mobile = 'true/false';
@jdalton jdalton added the change label Apr 14, 2017
chiefcll added a commit to Comcast/platform.js that referenced this issue Jan 22, 2018
Add Chrome Headless support as Chrome browser to keep it simple
for others to see as Chrome per Issue bestiejs#127.
@bnjmnt4n
Copy link
Member

bnjmnt4n commented Jan 23, 2018

Sorry for the late reply, this seems like a good idea - along with other changes such as adding platform.bot for detecting bots (and maybe headless browsers too?). This will probably only be available in v2 though.

@mshaaban088
Copy link

It might be a good idea to have set of flags (e.g. bot, headless, or mobile) but don't you think they are all mutually-exclusive (e.g. type: bot, type: headless, or type: mobile)

@trollkotze
Copy link

trollkotze commented Jul 15, 2018

How would one detect a bot?
I understand that one could a headless browser as such, and I guess almost all bots would operate through a headless browser. No?

Edit: Oh, [url=https://github.com//issues/67]I see[/url], some bots are so courteous to tell you who they are, while perusing various possible user agents for their mysterious purposes. (I don't know nuffin about bots.)

So I guess, not necessarily mutually exclusive, as there may be bots testing things for various platforms or headless or whatever.

omnibs pushed a commit to NoRedInk/platform.js that referenced this issue Jul 16, 2018
Add Chrome Headless support as Chrome browser to keep it simple
for others to see as Chrome per Issue bestiejs#127.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

5 participants