Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GPTable legend to dict #129

Open
foster999 opened this issue Sep 3, 2020 · 1 comment
Open

Change GPTable legend to dict #129

foster999 opened this issue Sep 3, 2020 · 1 comment
Labels
enhancement ✨ New feature or request
Milestone
v1.0

Comments

@foster999
Copy link
Contributor

Describe the solution you'd like
It would make sense to make the legend a dict of {marker: explanation} to ensure that structure is consistent. Especially given that we automatically generate a legend for missing values.

Note: would not be backwards compatible, though I haven't seen much use of the manual legend.
@foster999 foster999 added the enhancement ✨ New feature or request label Sep 3, 2020
@foster999 foster999 added this to the v0.4 milestone Sep 29, 2020
@rowanhemsi
Copy link
Collaborator

Note: as of v1.0.0, missing value behaviour has changed and legend is no longer automatically generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@foster999 @rowanhemsi