Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing requirements for R pre-commit hooks v0.1.3.9014+ #42

Open
ESKYoung opened this issue Jul 19, 2021 · 1 comment
Open

Missing requirements for R pre-commit hooks v0.1.3.9014+ #42

ESKYoung opened this issue Jul 19, 2021 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ESKYoung
Copy link
Collaborator

Whilst testing PR #39, I noticed that are documentation for R pre-commit hooks is missing a step, namely installing the R pre-commit package.

If this step is skipped, the styler hook will not run. Need some help from R users here.
@ESKYoung ESKYoung added bug Something isn't working help wanted Extra attention is needed documentation Improvements or additions to documentation labels Jul 19, 2021
@ESKYoung ESKYoung changed the title Missing instructions for R pre-commit hooks Missing requirements for R pre-commit hooks Jul 20, 2021
@ESKYoung
Copy link
Collaborator Author

This appears to be more widespread than originally thought. Bumping the R precommit package to v0.1.3.9014 has caused some problems wider than PR #41. Given limited time for me to fix this, I'm going to revert the PR for now (PR #44).

@ESKYoung ESKYoung changed the title Missing requirements for R pre-commit hooks Missing requirements for R pre-commit hooks v0.1.3.9014+ Jul 20, 2021
@ESKYoung ESKYoung removed the documentation Improvements or additions to documentation label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ESKYoung