Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinks converted to regular files on merge #110

Open
averms opened this issue Dec 12, 2021 · 1 comment
Open

Symlinks converted to regular files on merge #110

averms opened this issue Dec 12, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@averms
Copy link

averms commented Dec 12, 2021

Looking at the jre/legal folder in build/:

├── legal
│   ├── java.base
│   │   ├── ADDITIONAL_LICENSE_INFO
│   │   ├── aes.md
│   │   ├── asm.md
│   │   ├── ASSEMBLY_EXCEPTION
│   │   ├── cldr.md
│   │   ├── c-libutl.md
│   │   ├── icu.md
│   │   ├── LICENSE
│   │   ├── public_suffix.md
│   │   └── unicode.md
│   └── jdk.unsupported
│       ├── ADDITIONAL_LICENSE_INFO -> ../java.base/ADDITIONAL_LICENSE_INFO
│       ├── ASSEMBLY_EXCEPTION -> ../java.base/ASSEMBLY_EXCEPTION
│       └── LICENSE -> ../java.base/LICENSE

We can see that the license files in jdk.unsupported link to the ones in
java.base. After merging to the image folder in build/ we get

├── legal
│   ├── java.base
│   │   ├── ADDITIONAL_LICENSE_INFO
│   │   ├── aes.md
│   │   ├── asm.md
│   │   ├── ASSEMBLY_EXCEPTION
│   │   ├── cldr.md
│   │   ├── c-libutl.md
│   │   ├── icu.md
│   │   ├── LICENSE
│   │   ├── public_suffix.md
│   │   └── unicode.md
│   └── jdk.unsupported
│       ├── ADDITIONAL_LICENSE_INFO
│       ├── ASSEMBLY_EXCEPTION
│       └── LICENSE

The license files in jdk.unsupported are turned into regular files with 777
permissions. I imagine the symlink removal is on purpose (symlinks in zip files
don't work with Windows anyway), but why are the permissions changed?

@hakanai
Copy link
Collaborator

hakanai commented Jan 15, 2023

There's an open issue about symlink copying for Gradle itself: gradle/gradle#3982

It wouldn't surprise me if this is just another casualty of that.

It might be possible to work around it, but the best outcome is they fix it.

@hakanai hakanai added the bug Something isn't working label Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants